This repository has been archived by the owner on May 24, 2019. It is now read-only.
Add --copy-source option (.flow) #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very helpful and a nice way to author flow packages. |
Closed
|
@leebyron, any chance you could take a look at this PR? |
This was referenced Jul 6, 2018
Closed
mattgstevens
added a commit
to mattgstevens/eth-events-interface
that referenced
this pull request
Sep 13, 2018
one day this will be included in flow-remove-types facebookarchive/flow-remove-types#64
Closed
|
While it's nice from a performance standpoint not to have to read the source files twice, I don't know that this is strictly necessary given that https://github.com/Macil/flow-copy-source exists, and the fact that we have plans to resurrect gen-flow-files as the official solution for generating |
|
All good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
-c, --copy-sourceoptions to Copy typed source with .flow extension to output which Only applies when --out-file or --out-dir options are used.Using this option will copy
src/file.exttodest/file.ext.flow(whereextis any extension supported byflow-remove-types) anytime there is an output file.